> ----- Mensaje original ----- > De: "Yuyang Du" <yuyang.du@xxxxxxxxxxxxxxx> > Para: "Shuah Khan" <shuahkh@xxxxxxxxxxxxxxx> > CC: "Juan Zea" <juan.zea@xxxxxxxxxx>, shuah@xxxxxxxxxx, "Bjørn Mork" <bjorn@xxxxxxx>, linux-usb@xxxxxxxxxxxxxxx, "Valentina Manea" <valentina.manea.m@xxxxxxxxx> > Enviados: Martes, 21 de Noviembre 2017 8:45:33 > Asunto: Re: usbip port number limits > > On Wed, Nov 15, 2017 at 07:58:24AM -0700, Shuah Khan wrote: > > Hi Juan, > > > > On 11/15/2017 07:43 AM, Juan Zea wrote: > > > > > >>> Also, will you be able to revert the usb3 commit > > >>> 1c9de5bf428612458427943b724bea51abde520a > > >>> > > >>> and see if any of the problems go away. > > >>> > > >>> thanks, > > >>> -- Shuah > > >>> > > > > > >> I'm on it and will send results later. > > > > > >> Thanks, > > >> Juan > > > > > > Ok, I'm back. The revert was quite complex, with several conflicts I was not able to resolve. So I started testing full checkouts around that series of changes by Yuyang. > > > > I was hoping it will be easier. I was apprehensive it could be a com[ex revert. :( > > > > > That led me to bisecting the problem with the fingerprint reader, and the culprit is here: > > > > > > 03cd00d538a6feb0492cd153edf256ef7d7bd95e is the first bad commit > > > commit 03cd00d538a6feb0492cd153edf256ef7d7bd95e > > > Author: Yuyang Du <yuyang.du@xxxxxxxxx> > > > Date: Thu Jun 8 13:04:09 2017 +0800 > > > > > > usbip: vhci-hcd: Set the vhci structure up to work > > > > > > This patch enables the new vhci structure. Its lock protects > > > both the USB2 hub and the shared USB3 hub. > > > > > > Signed-off-by: Yuyang Du <yuyang.du@xxxxxxxxx> > > > Acked-by: Shuah Khan <shuahkh@xxxxxxxxxxxxxxx> > > > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > > > > > :040000 040000 b7b5c6b16db801c74354bb0d0a247855f64b0829 72524e78d281ebc8d36fa32cb93ed0278e99f880 M drivers > > > > > > The commit before, fingerprint reader works. Also, multicontroller works (no usb3 ports). > > > In this bad commit, I get the errors I sent in the previous message. > > > > > > > Thanks for reporting and debugging the problem to isolate the commit. I was > > suspecting one of these commit based on the messages you are seeing. > > > > I will see if I can fix this without doing a huge reverts. > > > Hi, > > Sorry for the latency. It seems now the bug is: > > Nov 14 14:35:29 kernel-tester kernel: [ 229.636543] kernel BUG at drivers/usb/usbip/vhci_hcd.c:683! > > which is a hard one (you mentioned the lastest kernel is used). > > Since you didn't post patch, lets first make sure we are on the same > page. Could you please try the following patch and see whether the > bug still exists? > > Also, I'm assuming you are using a non-super-speed device. > > Thanks, > Yuyang > > - Hi, Please excuse me... I have reported two different problems in this post, and I think things are mixing up a bit. My bad. I've found two different problems: 1.- When compiling vhci driver with multiple hubs (in latest kernel), usbip tool doesn't seem able to "jump" to the second controller. As far as I understand, it seems to be a problem with high speed devices trying to get connected to super speed ports. I made a patch for avoiding this situation which is almost the same as the one you just sent. Both patches work. I can compile with several hubs of one port, and connect two devices via usbip and the second gets connected to the second controller (skipping the super speed port of first controller). 2.- The problem is some of these devices don't work, whatsoever controller or hub compiling configuration I do. A fingerprint reader and also recently discovered flash usb sticks don't work either. You can connect them with usbip tool, and they list with lsusb with no problem at all. But when you try to use them, you get this "kernel BUG at drivers/usb/usbip/vhci_hcd.c:669!" (by the way, the line number has changed in the latest pull from master I've just tested, but it's the same line of code). This second problem is the one I bisected in my last message. And I got to the commit 03cd00d538a6feb0492cd153edf256ef7d7bd95e, in which both devices stop working. The patch you sent fixes 1 but not 2. And yes, I'm using non-super-speed devices for testing. I hope this helped, and sorry for the mess, Juan Juan Antonio Zea Herranz Proyectos y consultoría | Qindel Group E: juan.zea@xxxxxxxxxx T: +34 91 766 24 21 M: +34 637 74 63 09 W: qindel.com -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
