From: Anand Gadiyar <gadiyar@xxxxxx> MUSB: Use Mode 1 for TX if transfer size equals maxpacket Without this change, musb will not correctly send out a ZLP if the last transfer is exactly equal to the maxpacket size and request->zero is set. CC: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx> Signed-off-by: Anand Gadiyar <gadiyar@xxxxxx> --- (Resending with [PATCH] tag, and linux-omap CC'ed) Currently we use Mode 0 if transfer size is less-than-or-equal-to maxpacket. This requires that we explicitly set TxPktRdy for that transfer. However the musb_g_rx code will not set TxPktRdy twice if the last transfer is exactly equal to maxpacket, even if request->zero is set. Using Mode 1 will solve this, but maybe a better fix might be in musb_g_rx() diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gadget.c index c7ebd08..2807988 100644 --- a/drivers/usb/musb/musb_gadget.c +++ b/drivers/usb/musb/musb_gadget.c @@ -304,7 +304,7 @@ static void txstate(struct musb *musb, struct musb_request *req) /* setup DMA, then program endpoint CSR */ request_size = min(request->length, musb_ep->dma->max_len); - if (request_size <= musb_ep->packet_sz) + if (request_size < musb_ep->packet_sz) musb_ep->dma->desired_mode = 0; else musb_ep->dma->desired_mode = 1; -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
