> On Sep 27, 2017, at 9:39 AM, Grant Grundler <grundler@xxxxxxxxxxxx> wrote: > > On Wed, Sep 27, 2017 at 12:15 AM, Oliver Neukum <oneukum@xxxxxxxx> wrote: >> Am Dienstag, den 26.09.2017, 08:19 -0700 schrieb Doug Anderson: >>> >>> I know that for at least some of the adapters in the CDC Ethernet >>> blacklist it was claimed that the CDC Ethernet support in the adapter >>> was kinda broken anyway so the blacklist made sense. ...but for the >>> Linksys Gigabit adapter the CDC Ethernet driver seems to work OK, it's >>> just not quite as full featured / efficient as the R8152 driver. >>> >>> Is that not a concern? I guess you could tell people in this >>> situation that they simply need to enable the R8152 driver to get >>> continued support for their Ethernet adapter? >> >> Hi, >> >> yes, it is a valid concern. An #ifdef will be needed. > > Good idea - I will post V3 shortly. > > I'm assuming you mean to add #ifdef CONFIG_USB_RTL8152 around the > blacklist entry in cdc_ether driver. Shouldn't that be an #if IS_ENABLED(...) test, since that seems to be the proper way to check configured drivers. -- Mark Rustad, Networking Division, Intel Corporation
Attachment:
signature.asc
Description: Message signed with OpenPGP
