On 09/20/2017 11:21 AM, Sergei Shtylyov wrote:
> Hello!
>
> On 9/20/2017 10:35 AM, Alexandre Bailon wrote:
>
>> Currently, the number of channels is set to 15 but in the case of DA8xx,
>> the number of channels is 4.
>> Update the driver to configure the number of channels at runtime.
>>
>> Signed-off-by: Alexandre Bailon <abailon@xxxxxxxxxxxx>
>> ---
>> drivers/usb/musb/musb_cppi41.c | 31 ++++++++++++++++++++++++++-----
>> 1 file changed, 26 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/usb/musb/musb_cppi41.c
>> b/drivers/usb/musb/musb_cppi41.c
>> index b2b1306c01cf..2d1468cccae0 100644
>> --- a/drivers/usb/musb/musb_cppi41.c
>> +++ b/drivers/usb/musb/musb_cppi41.c
> [...]
>> @@ -770,18 +776,33 @@ cppi41_dma_controller_create(struct musb *musb,
>> void __iomem *base)
>> controller->tdown_reg = DA8XX_USB_TEARDOWN;
>> controller->autoreq_reg = DA8XX_USB_AUTOREQ;
>> controller->set_dma_mode = da8xx_set_dma_mode;
>> + controller->num_channels = DA8XX_DMA_NUM_CHANNELS;
>> } else {
>> controller->tdown_reg = USB_TDOWN;
>> controller->autoreq_reg = USB_CTRL_AUTOREQ;
>> controller->set_dma_mode = cppi41_set_dma_mode;
>> + controller->num_channels = MUSB_DMA_NUM_CHANNELS;
>> }
>> + channel_size = controller->num_channels *
>> + sizeof(struct cppi41_dma_channel);
>> + controller->rx_channel = kzalloc(channel_size, GFP_KERNEL);
>> + if (controller->rx_channel)
>
> How can this work? The NULL check is reversed.
Indeed! That's a good question! I have tested the series before to send
it but I could not explain why it have worked.
Anyway, I will fix it.
Best Regards,
Alexandre
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
