Hi, On 3 July 2017 at 16:53, Charles Keepax <ckeepax@xxxxxxxxxxxxxxxxxxxxx> wrote: > On Mon, Jul 03, 2017 at 02:07:15PM +0800, Baolin Wang wrote: >> Integrate with the newly added USB charger interface to limit the current >> we draw from the USB input based on the input device configuration >> identified by the USB stack, allowing us to charge more quickly from high >> current inputs without drawing more current than specified from others. >> >> Signed-off-by: Mark Brown <broonie@xxxxxxxxxx> >> Signed-off-by: Baolin Wang <baolin.wang@xxxxxxxxxx> >> --- > <snip> >> /********************************************************************* >> * Battery properties >> *********************************************************************/ >> @@ -607,6 +647,22 @@ static int wm831x_power_probe(struct platform_device *pdev) >> } >> } >> >> + power->usb_phy = devm_usb_get_phy_by_phandle(&pdev->dev, >> + "usb-phy", 0); >> + if (IS_ERR(power->usb_phy)) { >> + ret = PTR_ERR(power->usb_phy); >> + dev_err(&pdev->dev, "Failed to find USB phy: %d\n", ret); >> + goto err_bat_irq; >> + } >> + > > We should probably update the binding documentation for this as > well: mfd/wm831x.txt Yes, I will update the binding documentation. > > Also I am not sure this needs to be implemented now, but what is > the plan regarding pdata systems? Generally the driver supports > both and it would be nice to know there is a way forward for that > even if we don't implement it yet. OK, I'll modify this in next version. Thanks. -- Baolin.wang Best Regards -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html