On Thu, Mar 05, 2009 at 04:28:56PM +0600, Ivan Avdeev wrote: > This patch effectively fixes the bug #11585 [1] for me. It does so by > assigning minor number to device before calling attach() function. The > reason for this bug to appear is apparently that mos7840_startup() > function uses minor variable, which was unitialized at the moment. The > reason for this to appear now, but not earlier, is that mos7840 module > was supposedly tested only using just one device, for which case minor > was equal to the very same zero value before and after its > initialization. The TTY_NO_MINOR patch changed the initial value, and > that broke everything. > > I can't check if this patch breaks other devices, because I don't have > any. Neither do I have enough experience to figure this out from reading > sources. So, please test. > > PS: As far as I'm concerned the latest 2.6.28.7 kernel still has this > bug. The fix is the same but line numbers. Hm, this doesn't apply at all to the latest kernel tree, can you forward port it? I'll back-port it after it goes into Linus's tree to the -stable kernel trees, so you don't have to worry about that. Also, can you add a "Signed-off-by:" line to the patch when you resend it, as documented in Documentation/SubmittingPatches? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
