On Jun 13 2017 or thereabouts, Benjamin Tissoires wrote:
> On Jun 13 2017 or thereabouts, Jiri Kosina wrote:
> > So I've now pushed the latest version to 'for-4.12/driver-matching-fix' of
> > hid.git, and if no more issues are discovered, I'll push that to Linus
> > this week so that we finally get rid of this long-lasting PITA (while
> > still heading towards 'automatic' proper matching -- Benjamin already had
> > some proposals how to tackle this).
>
> Hi Jiri,
>
> I tried to cook some script that formats the list in the same way than
> yours.
>
> I just noticed that you have in CONFIG_HID_CHICONY:
> { HID_USB_DEVICE(USB_VENDOR_ID_CHICONY, USB_DEVICE_ID_ASUS_AK1D) },
> while in v4.12-rc5 it's:
> { HID_USB_DEVICE(USB_VENDOR_ID_CHICONY, USB_DEVICE_ID_CHICONY_AK1D) },
> ^^^^^^^
False alert on this one. I applied Jiri's patch on top of his for-next
branch, and in this branch, this has been renamed into
USB_DEVICE_ID_ASUS_AK1D.
>
> Rest is almost OK with respect to device/driver allocation:
>
> Also, comparing the raw number of devices, there are 356 devices in
> 4.12-rc5, and you have 360 in your patch:
> - { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_LOGITECH_G920_WHEEL) }
> is added twice (the one in CONFIG_HID_LOGITECH should be dropped IMO).
Only this one is would require a change now.
Cheers,
Benjamin
> - { HID_USB_DEVICE(USB_VENDOR_ID_UCLOGIC, USB_DEVICE_ID_HUION_TABLET) },
> appeared, which is fine according to hid-uclogic.c
> - The two bluetooth devices for hid-gfrm.c are legitimate too.
>
> So fixing the extra USB_DEVICE_ID_LOGITECH_G920_WHEEL and the messed up
> USB_DEVICE_ID_CHICONY_AK1D should be enough to have it in Linus' tree.
>
> BTW, the merge with your for-next branch is going to be tricky :(
>
> Cheers,
> Benjamin
>
> >
> > Thanks,
> >
> > --
> > Jiri Kosina
> > SUSE Labs
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
