On Mon, Mar 09, 2009 at 02:36:50PM -0400, Dan Williams wrote: > On Mon, 2009-03-09 at 19:32 +0100, oliver@xxxxxxxxxx wrote: > > > Following the general example of the 'hso' driver, this patch > > implements > > > modem port types using a 'port_type' attribute in the tty's sysfs > > > directory. Port types for genuine Option NV devices are added by > > this > > > patch, but types for other manufacturers devices may follow. I > > intend > > > to submit a patch to hso that adds these "standard" port types to > > that > > > driver as well. > > > > It seems to me most of this belongs into the generic layer. Also, > > You mean the generic tty layer? The usb-serial layer would be a good first start, but then you need to also do the same thing for the cdc-acm and cdc-wdm and hso drivers, right? So probably the tty layer. I see what you are trying to solve here, however, you are just pushing the need to create this table from userspace, into the kernel. While this is nice from a userspace point of view, I thought that this is what the modem-id userspace tool was trying to do. What's wrong with that? Also, I as a kernel developer do not know a lot of this, especially when users and random developers just email me new device ids. How am I supposed to get this information from the users/developers as to which port is which? So I think you are just moving the data down out of hal-device-info, into the kernel, for no real benifit other than not having to maintain the tables yourself :) thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
