On Sat, Mar 07, 2009 at 01:11:28PM +0300, Sergei Shtylyov wrote:
>> --- a/drivers/usb/serial/ftdi_sio.c
>> +++ b/drivers/usb/serial/ftdi_sio.c
>> @@ -1942,7 +1942,7 @@ static void ftdi_process_read(struct wor
>> priv->prev_status = new_status;
>> }
>> - length = min(PKTSZ, urb->actual_length-packet_offset)-2;
>> + length = min_t(u32, PKTSZ, urb->actual_length-packet_offset)-2;
>>
>
> You could ass spaces around - while at it...
Around the "-2"? No, then you go over 80 columns.
>> --- a/include/linux/usb.h
>> +++ b/include/linux/usb.h
>> @@ -1178,7 +1178,7 @@ struct urb {
>> void *transfer_buffer; /* (in) associated data buffer */
>> dma_addr_t transfer_dma; /* (in) dma addr for transfer_buffer */
>> u32 transfer_buffer_length; /* (in) data buffer length */
>> - int actual_length; /* (return) actual transfer length */
>> + u32 actual_length; /* (return) actual transfer length */
>> unsigned char *setup_packet; /* (in) setup packet (control only) */
>> dma_addr_t setup_dma; /* (in) dma addr for setup_packet */
>> int start_frame; /* (modify) start frame (ISO) */
>
>
> I'm not sure this was worth a separate patch...
One thing per patch is the rule where ever possible.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
