On Fri, Mar 06, 2009 at 08:25:05PM +0100, Martin Bammer wrote: > > On Fri, Mar 06, 2009 at 10:51:12AM -0800, Greg KH wrote: > > > On Fri, Mar 06, 2009 at 07:38:04PM +0100, Martin Bammer wrote: > > > > Sorry, didn't know about checkpatch.pl and linux-usb@xxxxxxxxxxxxxxxx > > > > Also I didn't see that delay_use is a module parameter. > > > > So the patch didn't exactly do what it should. Now here is a new patch > > > > which should work. The reason for the checks against manufacturer, > > > > product and serial number is to detect memory devices. These devices are > > > > ready for partition scanning much earlier than harddrives. So the scan > > > > delay is set to a shorter time for these devices. > > > > > > Are you sure they are always ready for partition scanning faster than > > > harddrives? How do you know that? > > > > I know, for a fact, that flash/memory devices are NOT always faster than > > spinning media when it comes to "being ready". > > > > This batch is bogus. NAK. > > > > Ok, under this circumstances this patch can't be included in the > mainline kernel. Um, it shouldn't be included in anyone's kernel as it's flat out wrong, and potentially dangerous for some devices. You've just gotten lucky so far. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
