On Thu, May 11, 2017 at 09:40:28AM -0600, Shuah Khan wrote:
> On 05/10/2017 10:18 AM, Johan Hovold wrote:
> > Fix up the root-hub descriptor to accommodate the variable-length
> > DeviceRemovable and PortPwrCtrlMask fields, while marking all ports as
> > removable (and leaving the reserved bit zero unset).
> >
> > Also add a build-time constraint on VHCI_HC_PORTS which must never be
> > greater than USB_MAXCHILDREN (but this was only enforced through a
> > KConfig constant).
> >
> > This specifically fixes the descriptor layout whenever VHCI_HC_PORTS is
> > greater than seven (default is 8).
> >
> > Fixes: 04679b3489e0 ("Staging: USB/IP: add client driver")
> > Cc: Takahiro Hirofuchi <hirofuchi@xxxxxxxxxxxxxxxxxxxxx>
> > Cc: Valentina Manea <valentina.manea.m@xxxxxxxxx>
> > Cc: Shuah Khan <shuah@xxxxxxxxxx>
> > Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>
>
> Change looks reasonable to me. Why did you send v2 so quickly.
> v1 and v2 look identical to me. Please mention the changes if any
> made to v1 when you send v2 in the future. It will make easier
> for reviewers.
There was a change made to the first patch of this series. The changelog
was in cover letter which I forgot to CC you.
> In any case, here is my Ack for Greg to take this patch:
>
> Acked-by: Shuah Khan <shuahkh@xxxxxxxxxxxxxxx>
Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
