Hi, Bin Liu <b-liu@xxxxxx> writes: >> Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> writes: >> >>> Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> writes: >> >> > On Tue, May 09, 2017 at 10:10:45AM +0300, Felipe Balbi wrote: >> >> >> >> >> >> Hi, >> >> >> >> >> >> Felipe Balbi <felipe.balbi@xxxxxxxxxxxxxxx> writes: >> >> >> > Document a few details about DWC3 in order to help people report bugs >> >> >> > and debug DWC3. >> >> >> > >> >> >> > Signed-off-by: Felipe Balbi <felipe.balbi@xxxxxxxxxxxxxxx> >> >> >> > --- >> >> >> > Documentation/usb/dwc3.rst | 712 +++++++++++++++++++++++++++++++++++++++++++++ >> >> >> >> >> >> hmm, maybe this should be moved to Documentation/driver-api/usb/ ? >> >> > >> >> > If that's where the files have moved to, yes, that is where this should >> >> > be. >> >> >> >> alright, I'll update $subject and add another moving two other files >> >> which remained in Documentation/usb/ >> >> >> >> I'd like to get a feeling for patch 6/7 though, if it's not too much to >> >> ask. I wonder if there would be more interested users for that mechanism. >> > >> > A bit like "usbmon translated into english", right? I like it, let's >> > see how helpful it is here, and if so, I wouldn't object to adding it to >> > the USB core for other drivers to use. >> >> Right, I think it could be useful for other drivers adding >> tracepoints. I got tired of always decoding those bytes manually and >> decided to let the computer do it for me :-p >> >> For example, xHCI has a tracepoint for ctrl transfers which could rely >> on this mechanism. It shouldn't be difficult to make it generic. > > I like it too. > After read the patch commit log, I am concerned about the timing > overhead added by the decoding, but then read the patch, it is only for > ctrl transfers, so timing overhead shouldn't be an issue. there should be no problems with any timing. Decoding is done at TP_printk() which is only executed when you read 'trace' file. Everything is done after the fact. -- balbi
Attachment:
signature.asc
Description: PGP signature
