On Thursday 26 February 2009, Qiuping Chen wrote: > Change __constant_cpu_to_le32 to cpu_to_le32. > > This patch Add support for OID OID_802_3_MAXIMUM_LIST_SIZE and > OID_802_3_MAC_OPTIONS in rndis.c to make > RNDIS gadget pass 1c_SetMulticast test in Microsoft NDISTest6. > > The other tests in NDISTest6 are passed. > > Signed-off-by: Helen Chen <helen.chen@xxxxxxxxx> I see a technical problem here though. This now says that it supports 32 multicast addresses ... but the driver doesn't actually support any, it ignores them. (While the comment says it supports exactly one; sigh.) Which is a clear sign of a bad testcase, but that's another issue. What's the impact of lying about this support, when a host tries to use it? - Dave [1] http://msdn.microsoft.com/en-us/library/aa925864.aspx > --- > drivers/usb/gadget/rndis.c | 4 +- > 1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/drivers/usb/gadget/rndis.c b/drivers/usb/gadget/rndis.c > index 8c26f5e..67fb17c 100644 > --- a/drivers/usb/gadget/rndis.c > +++ b/drivers/usb/gadget/rndis.c > @@ -439,12 +439,14 @@ gen_ndis_query_resp (int configNr, u32 OID, u8 > *buf, unsigned buf_len, > case OID_802_3_MAXIMUM_LIST_SIZE: > pr_debug("%s: OID_802_3_MAXIMUM_LIST_SIZE\n", __func__); > /* Multicast base address only */ > - *outbuf = cpu_to_le32 (1); > + *outbuf = cpu_to_le32(32); > retval = 0; > break; > > case OID_802_3_MAC_OPTIONS: > pr_debug("%s: OID_802_3_MAC_OPTIONS\n", __func__); > + *outbuf = cpu_to_le32(0); > + retval = 0; > break; > break; > > /* ieee802.3 statistics OIDs (table 4-4) */ > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
