Re: [PATCH] usb: hub: judge BOS field in usb_reset_and_verify_device()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 02, 2017 at 02:31:40PM +0800, wangjianxing5210@xxxxxxx wrote:
> From: "Jianxing.Wang" <wangjianxing5210@xxxxxxx>
> 
> When notebook with intel-3165-wifi suspend and resume,crash for
> udev->bos is NULL.

I'm sorry, I don't understand, how can udev->bos be NULL here?  Why does
the wifi device matter to the USB device?

> 
> Signed-off-by: Jianxing.Wang <wangjianxing5210@xxxxxxx>
> ---
>  drivers/usb/core/hub.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
> index 5286bf6..3b5493a 100644
> --- a/drivers/usb/core/hub.c
> +++ b/drivers/usb/core/hub.c
> @@ -4281,10 +4281,12 @@ static void hub_set_initial_usb2_lpm_policy(struct usb_device *udev)
>  	if (hub)
>  		connect_type = hub->ports[udev->portnum - 1]->connect_type;
>  
> -	if ((udev->bos->ext_cap->bmAttributes & cpu_to_le32(USB_BESL_SUPPORT)) ||
> -			connect_type == USB_PORT_CONNECT_TYPE_HARD_WIRED) {
> -		udev->usb2_hw_lpm_allowed = 1;
> -		usb_set_usb2_hardware_lpm(udev, 1);
> +	if (udev->bos != NULL) {

This is already checked a few lines above this, how can it have changed
already?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux