On Tue, May 02, 2017 at 12:05:48PM +0200, Anthony Mallet wrote: > On Tuesday 2 May 2017, at 10:34, Johan Hovold wrote: > > On Fri, Apr 28, 2017 at 11:27:20AM +0200, Anthony Mallet wrote: > > > This is due to commit 557aaa7 > > > https://github.com/torvalds/linux/commit/557aaa7ffab639d0190b935a041b16ae44606342 > > > that silently/partially ignores the ASYNC_LOW_LATENCY flag in > > > set_serial_info(), without returning EPERM, although > > > ASYNC_LOW_LATENCY is explicitly listed in ASYNC_USR_MASK. > > > > Actually that commit did enable non-privileged users to set the flag, but > > it would not take effect until next open. A later commit then broke this > > behaviour, but no one has noticed for about seven years. > > OK. Thanks for reviewing this. > (Not taking effect until next open was a bit bad too, I think). Agreed, but I think it may have been for consistency with how the legacy low_latency flag was handled. > > Yes, this looks like the right fix. > > > > Are you going to submit this as a proper patch that we can apply? > > Sure (I was just AFK for the week-end). > > Is it OK like this ? The diff itself is fine, but a patch needs to have a proper commit summary (email Subject), commit message (email body before the diff) and include a Signed-off-by line. Please make sure to read Documentation/process/submitting-patches.rst as Greg suggested. Here's an example of what the end-result may look like: https://lkml.kernel.org/r/20170125143520.10982-1-johan@xxxxxxxxxx Note that text below the cut-off-line (---) is not included in the commit message when applied and can therefore be used for meta information such a changelog. Thanks, Johan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
