Re: USB-related lock inversion complaint

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2017-05-01 at 13:39 -0400, Alan Stern wrote:
> On Fri, 28 Apr 2017, Alan Stern wrote:
> > On Fri, 28 Apr 2017, Bart Van Assche wrote:
> He wrote:
> 
> > There, that's where we hold the lock with interrupts enabled.
> > 
> > So someone forced interrupt threading and the code assumes the interrupt
> > code has IRQs disabled or something along those lines.
> 
> So we should be able to fix the problem by changing spin_lock/unlock in
> xhci_irq() to spin_lock_irqsave/restore.  Bart, please try out the
> patch below.

Hello Alan,

Thanks for getting back to me and sorry that I forgot to mention that I had
enabled interrupt threading. Is the patch you posted against a USB tree that
is not yet upstream? It did not apply cleanly against kernel v4.11. But a
backport of that patch to kernel v4.11 made the lock inversion complaints
disappear so I think you can add:

Tested-by: Bart Van Assche <bart.vanassche@xxxxxxxxxxx>--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux