Hi Mats,
On Tue, Apr 25, 2017 at 11:49:47PM +0200, Mats Karrman wrote:
> In some situations, e.g. when registering alternate modes for local typec
> ports, it may be handy to use constant mode descriptors. Allow this by
> changing the mode descriptor arguments of typec_port_register_altmode()
> et.al. to using const pointers.
>
> Signed-off-by: Mats Karrman <mats.dev.list@xxxxxxxxx>
> Reviewed-by: Guenter Roeck <groeck@xxxxxxxxxxxx>
This is OK by me. FWIW:
Acked-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
FYI, in case you guys are interested, I'm collecting all the typec
stuff to my github tree [1] "typec" branch.
[1] git://github.com/krohei/linux
Thanks Mats,
> ---
> drivers/usb/typec/typec.c | 11 ++++++-----
> include/linux/usb/typec.h | 6 +++---
> 2 files changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/usb/typec/typec.c b/drivers/usb/typec/typec.c
> index 89e540b..db5ee73 100644
> --- a/drivers/usb/typec/typec.c
> +++ b/drivers/usb/typec/typec.c
> @@ -291,7 +291,7 @@ typec_altmode_roles_show(struct device *dev, struct device_attribute *attr,
> }
>
> static void typec_init_modes(struct typec_altmode *alt,
> - struct typec_mode_desc *desc, bool is_port)
> + const struct typec_mode_desc *desc, bool is_port)
> {
> int i;
>
> @@ -378,7 +378,8 @@ static const struct device_type typec_altmode_dev_type = {
> };
>
> static struct typec_altmode *
> -typec_register_altmode(struct device *parent, struct typec_altmode_desc *desc)
> +typec_register_altmode(struct device *parent,
> + const struct typec_altmode_desc *desc)
> {
> struct typec_altmode *alt;
> int ret;
> @@ -495,7 +496,7 @@ EXPORT_SYMBOL_GPL(typec_partner_set_identity);
> */
> struct typec_altmode *
> typec_partner_register_altmode(struct typec_partner *partner,
> - struct typec_altmode_desc *desc)
> + const struct typec_altmode_desc *desc)
> {
> return typec_register_altmode(&partner->dev, desc);
> }
> @@ -590,7 +591,7 @@ static const struct device_type typec_plug_dev_type = {
> */
> struct typec_altmode *
> typec_plug_register_altmode(struct typec_plug *plug,
> - struct typec_altmode_desc *desc)
> + const struct typec_altmode_desc *desc)
> {
> return typec_register_altmode(&plug->dev, desc);
> }
> @@ -1159,7 +1160,7 @@ EXPORT_SYMBOL_GPL(typec_set_pwr_opmode);
> */
> struct typec_altmode *
> typec_port_register_altmode(struct typec_port *port,
> - struct typec_altmode_desc *desc)
> + const struct typec_altmode_desc *desc)
> {
> return typec_register_altmode(&port->dev, desc);
> }
> diff --git a/include/linux/usb/typec.h b/include/linux/usb/typec.h
> index ec78204..d1d2ebc 100644
> --- a/include/linux/usb/typec.h
> +++ b/include/linux/usb/typec.h
> @@ -117,13 +117,13 @@ struct typec_altmode_desc {
>
> struct typec_altmode
> *typec_partner_register_altmode(struct typec_partner *partner,
> - struct typec_altmode_desc *desc);
> + const struct typec_altmode_desc *desc);
> struct typec_altmode
> *typec_plug_register_altmode(struct typec_plug *plug,
> - struct typec_altmode_desc *desc);
> + const struct typec_altmode_desc *desc);
> struct typec_altmode
> *typec_port_register_altmode(struct typec_port *port,
> - struct typec_altmode_desc *desc);
> + const struct typec_altmode_desc *desc);
> void typec_unregister_altmode(struct typec_altmode *altmode);
>
> struct typec_port *typec_altmode2port(struct typec_altmode *alt);
> --
> 2.1.4
--
heikki
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
