On Tue, 25 Apr 2017, Felipe Balbi wrote: > Currently, default vary will not accomodate superspeed endpoints > causing unexpected babble errors in the IN direction. Let's update > default 'vary' parameter so that we can maintain a "short-less" > transfer as hinted at the comment. > > Reported-by: Ammy Yi <ammy.yi@xxxxxxxxx> > Signed-off-by: Felipe Balbi <felipe.balbi@xxxxxxxxxxxxxxx> > --- > tools/usb/testusb.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/tools/usb/testusb.c b/tools/usb/testusb.c > index 0692d99b6d8f..7c418fa87194 100644 > --- a/tools/usb/testusb.c > +++ b/tools/usb/testusb.c > @@ -387,6 +387,8 @@ int main (int argc, char **argv) > /* pick defaults that works with all speeds, without short packets. > * > * Best per-frame data rates: > + * super speed,bulk 1024 * 16 * 13 = 212992 > + * interrupt 1024 * 3 * 8 = 24576 > * high speed, bulk 512 * 13 * 8 = 53248 > * interrupt 1024 * 3 * 8 = 24576 > * full speed, bulk/intr 64 * 19 = 1216 The first new comment line looks a little weird. The three numeric columns are: bytes/packet, packets/microframe, and microframes/frame. So it should be: * super speed,bulk 1024 * 16 * 8 = 131072 Yes? Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
