Re: issues with commit c1da59dad0eb ("cdc-wdm: Clear read pipeline in case of error")

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 2017-04-24 08:02 AM, Bjørn Mork wrote:
Aleksander Morgado <aleksander@xxxxxxxxxxxxx> writes:
On Thu, Apr 20, 2017 at 10:32 AM, Bjørn Mork <bjorn@xxxxxxx> wrote:
Sorry for being much too late here, but during recent attemts to debug
issues caused by my commit 833415a3e781 ("cdc-wdm: fix "out-of-sync" due
to missing notifications") I believe I found a couple of issues with
commit c1da59dad0eb. At least one of them is serious (potentional
GPF_KERNEL allocation in interrupt context).

But I don't know if I understand the problem the commit set out to
solves, which is why I have no proposed patch here.

Just to be clear, the issues found with both commits are completely
unrelated one from the other, right?

No, they do interact and will most likely affect each other.

But this would not be an issue if commit 833415a3e781 didn't cause
unexpected errors, so that commit must be reverted in any case.

Alright, so assuming reversions are the way to go forward,
how would you prefer to go about cleaning this up?


Rob.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux