Re: Regression: asix: BISECTED suspend crash - Dell XPS13-9360

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Freddy, Robert, David,
Any clue here?
Seems to broken here:
static int asix_suspend(struct usb_interface *intf, pm_message_t message)
{
        struct usbnet *dev = usb_get_intfdata(intf);
	struct asix_common_private *priv = dev->driver_priv;

	if (priv->suspend) //priv is NULL

thanks,
Yu
On Tue, Apr 18, 2017 at 08:36:16AM +0800, Zhang Rui wrote:
> Hi, Freddy,
> 
> We have a bug report that system suspend crashes if the asix
> USB/ETHERNET adapter is connected.
> https://bugzilla.kernel.org/show_bug.cgi?id=195431
> 
> 
> And the bisect result shows that 
> d9fe64e511144c1ee7d7555b4111f09dde9692ef is the first bad commit.
> 
> commit d9fe64e511144c1ee7d7555b4111f09dde9692ef
> Author: Robert Foss <robert.foss@xxxxxxxxxxxxx>
> Date:   Mon Aug 29 09:32:15 2016 -0400
> 
>     net: asix: Add in_pm parameter
>     
>     From: Freddy Xin <freddy@xxxxxxxxxxx>
>     
>     In order to R/W registers in suspend/resume functions, in_pm flags
> are
>     added to some functions to determine whether the nopm version of
> usb
>     functions is called.
>     
>     Save BMCR and ANAR PHY registers in suspend function and restore
> them
>     in resume function.
>     
>     Reset HW in resume function to ensure the PHY works correctly.
>     
>     Signed-off-by: Freddy Xin <freddy@xxxxxxxxxxx>
>     Signed-off-by: Robert Foss <robert.foss@xxxxxxxxxxxxx>
>     Tested-by: Robert Foss <robert.foss@xxxxxxxxxxxxx>
>     Signed-off-by: David S. Miller <davem@xxxxxxxxxxxxx>
> 
> can you please take a look at this problem?
> 
> thanks,
> rui
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux