Hello, I have tested it and it works great!!! Thank you very much!!!!!! I use nqc to test it and it has uploaded the firmware to the brick perfectly. [ 164.835935] usb 4-5: new low-speed USB device number 3 using ohci-pci [ 165.050272] usb 4-5: New USB device found, idVendor=0694, idProduct=0001 [ 165.050276] usb 4-5: New USB device strings: Mfr=4, Product=26, SerialNumber=0 [ 165.050278] usb 4-5: Product: LEGO USB Tower [ 165.050280] usb 4-5: Manufacturer: LEGO Group [ 165.055275] legousbtower 4-5:1.0: LEGO USB Tower firmware version is 1.0 build 134 [ 165.055481] legousbtower 4-5:1.0: LEGO USB Tower #-160 now attached to major 180 minor 0 HOME Escritorio # nqc -Susb -firmware ./firm0332.lgo Downloading firmware:............................................................................................................................. Current Version: 00030001/00030302 HOME Escritorio # uname -a Linux HOME 4.10.12 #1 SMP Sat Apr 22 09:30:06 CEST 2017 x86_64 x86_64 x86_64 GNU/Linux Thank you very much!!!! 2017-04-22 7:03 GMT+02:00 Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>: > On Fri, Apr 21, 2017 at 10:48:48PM +0300, Maksim Salau wrote: >> Allocate buffers on HEAP instead of STACK for local structures >> that are to be received using usb_control_msg(). >> >> Signed-off-by: Maksim Salau <maksim.salau@xxxxxxxxx> >> --- >> >> I took the liberty to fix the module if Greg don't mind. >> It is to be applied on vanilla v4.10.12 (without Greg's patch). > > Yeah! Thank you for this, I got distracted with stable kernel work for > the past few days. > >> Changes compared to Greg's version: >> * fixed tower_reset() which is used in the open callback; >> * better deallocation handling in case of failures. > > Alfredo, can you test this patch out? > > thanks again, > > greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
