Hi, > -----Original Message----- > From: Colin King [mailto:colin.king@xxxxxxxxxxxxx] > Sent: Tuesday, March 28, 2017 6:35 AM > To: Felipe Balbi; Greg Kroah-Hartman; YUAN Linyu; Bhumika Goyal; Michal > Nazarewicz; linux-usb@xxxxxxxxxxxxxxx > Cc: kernel-janitors@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx > Subject: [PATCH] usb: gadget: udc: remove redundant initial assignments to the > pointer 's' > > From: Colin Ian King <colin.king@xxxxxxxxxxxxx> > > The initial setting of pointer s to the driver name or to the literal > string "(none)" is redundant as later it is always set to point to > a different literal string before it is printed log. Remove this > redundant code. > > Detected with CoverityScan, CID#1227032, CID#1227033 ("Unused Value") > > Signed-off-by: Colin Ian King <colin.king@xxxxxxxxxxxxx> > --- > drivers/usb/gadget/udc/net2272.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/usb/gadget/udc/net2272.c > b/drivers/usb/gadget/udc/net2272.c > index 8f85a51bd2b3..dee4eb60d4c2 100644 > --- a/drivers/usb/gadget/udc/net2272.c > +++ b/drivers/usb/gadget/udc/net2272.c > @@ -1191,11 +1191,6 @@ registers_show(struct device *_dev, struct > device_attribute *attr, char *buf) > size = PAGE_SIZE; > spin_lock_irqsave(&dev->lock, flags); > > - if (dev->driver) > - s = dev->driver->driver.name; > - else > - s = "(none)"; > - > /* Main Control Registers */ > t = scnprintf(next, size, "%s version %s," > "chiprev %02x, locctl %02x\n" I think it's original purpose is not use driver_name directly in below scnprintf function call. You can change drivers_name below to s. /* Main Control Registers */ t = scnprintf(next, size, "%s version %s," "chiprev %02x, locctl %02x\n" "irqenb0 %02x irqenb1 %02x " "irqstat0 %02x irqstat1 %02x\n", driver_name, driver_vers, dev->chiprev, > -- > 2.11.0 ��.n��������+%������w��{.n�����{���)�� jg��� �����ݢj����G���� ���j:+v���w�m������w�������h�����٥
