Hi, Shuah Khan <shuahkh@xxxxxxxxxxxxxxx> writes: > dwc3_probe() does pm_runtime_put_sync() in its err1 handling when > pm_runtime_get_sync() fails. Move the pm_runtime_put_sync() under > err2 instead as it is used in error paths after pm_runtime_get_sync() > succeeds. there's nothing wrong with current code. Read the docs. Even if pm_runtime_get*() fails, you still need to decrement the usage counter. pm_runtime_put*() is one way of achieving so. -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html