On Thu, Feb 26, 2009 at 9:13 AM, Felipe Balbi <me@xxxxxxxxxxxxxxx> wrote:
> On Wed, Feb 25, 2009 at 08:53:00PM +0900, Kim Kyuwon wrote:
>> From: Kim Kyuwon <chammoru@xxxxxxxxx>
>>
>> While waking up, musb can cause a kernel panic. This patch is fixing
>> it by enabling the clock in the resume_early method.
>>
>> Signed-off-by: Kim Kyuwon <chammoru@xxxxxxxxx>
>> ---
>> drivers/usb/musb/musb_core.c | 21 +++++++--------------
>> 1 files changed, 7 insertions(+), 14 deletions(-)
>>
>> diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
>> index 2cc34fa..ae76ad7 100644
>> --- a/drivers/usb/musb/musb_core.c
>> +++ b/drivers/usb/musb/musb_core.c
>> @@ -2141,16 +2141,13 @@ static int __devexit musb_remove(struct
>> platform_device *pdev)
>>
>> #ifdef CONFIG_PM
>>
>> -static int musb_suspend(struct platform_device *pdev, pm_message_t message)
>> +static int musb_suspend_late(struct platform_device *pdev, pm_message_t state)
>> {
>> - unsigned long flags;
>> - struct musb *musb = dev_to_musb(&pdev->dev);
>> + struct musb *musb = dev_to_musb(&pdev->dev);
>
> this hunk is unecessary, please revert. I'll also take a closer look
> tomorrow, it's already really late and need some nap (as suggested by
> greg, hehe :-p)
>
OK, but before I resend the patch, I have something to check again.
Now I know that, in addition to HSUSB_MC_NINT disabled by the previous
patch [ARM: OMAP: Disable USB interrupt in the musb_resume()
function], USBTLL_SWAKEUP and USBHOST_SWAKEUP can be also wake-up
source events to PRMC module. Sorry I didn't know that time. The
remote wake uses these two SWAKEUP. David, is my previous patch is
still NAK?
> --
> balbi
>
--
Q1
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
