Re: [PATCH 1/2] usb: musb: fix the possible panic while resuming

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 25, 2009 at 08:53:00PM +0900, Kim Kyuwon wrote:
> From: Kim Kyuwon <chammoru@xxxxxxxxx>
> 
> While waking up, musb can cause a kernel panic. This patch is fixing
> it by enabling the clock in the resume_early method.
> 
> Signed-off-by: Kim Kyuwon <chammoru@xxxxxxxxx>
> ---
>  drivers/usb/musb/musb_core.c |   21 +++++++--------------
>  1 files changed, 7 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
> index 2cc34fa..ae76ad7 100644
> --- a/drivers/usb/musb/musb_core.c
> +++ b/drivers/usb/musb/musb_core.c
> @@ -2141,16 +2141,13 @@ static int __devexit musb_remove(struct
> platform_device *pdev)
> 
>  #ifdef	CONFIG_PM
> 
> -static int musb_suspend(struct platform_device *pdev, pm_message_t message)
> +static int musb_suspend_late(struct platform_device *pdev, pm_message_t state)
>  {
> -	unsigned long	flags;
> -	struct musb	*musb = dev_to_musb(&pdev->dev);
> +	struct musb *musb = dev_to_musb(&pdev->dev);

this hunk is unecessary, please revert. I'll also take a closer look
tomorrow, it's already really late and need some nap (as suggested by
greg, hehe :-p)

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux