This is a note to let you know that I've just added the patch titled Subject: USB: g_file_storage: automatically disable stalls under Atmel to my gregkh-2.6 tree. Its filename is usb-g_file_storage-automatically-disable-stalls-under-atmel.patch This tree can be found at http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/ >From stern@xxxxxxxxxxxxxxxxxxx Tue Feb 24 21:48:00 2009 From: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> Date: Tue, 24 Feb 2009 16:19:47 -0500 (EST) Subject: USB: g_file_storage: automatically disable stalls under Atmel To: Greg KH <greg@xxxxxxxxx> Cc: Stanislaw Gruszka <stf_xl@xxxxx>, USB list <linux-usb@xxxxxxxxxxxxxxx> Message-ID: <Pine.LNX.4.44L0.0902241617220.10601-100000@xxxxxxxxxxxxxxxxxxxx> This patch (as1220) automatically disables stalls when g_file_storage finds itself running with an Atmel device controller, because the Atmel hardware/driver isn't capable of halting bulk endpoints correctly. Reported-by: Stanislaw Gruszka <stf_xl@xxxxx> Signed-off-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> Acked-by: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx> --- drivers/usb/gadget/file_storage.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) --- a/drivers/usb/gadget/file_storage.c +++ b/drivers/usb/gadget/file_storage.c @@ -3879,7 +3879,11 @@ static int __init check_parameters(struc mod_data.protocol_type = USB_SC_SCSI; mod_data.protocol_name = "Transparent SCSI"; - if (gadget_is_sh(fsg->gadget)) + /* Some peripheral controllers are known not to be able to + * halt bulk endpoints correctly. If one of them is present, + * disable stalls. + */ + if (gadget_is_sh(fsg->gadget) || gadget_is_at91(fsg->gadget)) mod_data.can_stall = 0; if (mod_data.release == 0xffff) { // Parameter wasn't set Patches currently in gregkh-2.6 which might be from stern@xxxxxxxxxxxxxxxxxxx are usb/usb-ch341-serial-fix-port-number-changed-after-resume.patch usb/usb-ehci-add-software-retry-for-transaction-errors.patch usb/usb-ehci-make-timer_action-out-of-line.patch usb/usb-kill-prehistorical-comments-about-usb_ehci_hcd.patch usb/usb-storage-make-alauda-a-separate-module.patch usb/usb-storage-make-cypress_atacb-a-separate-module.patch usb/usb-storage-make-datafab-a-separate-module.patch usb/usb-storage-make-freecom-a-separate-module.patch usb/usb-storage-make-isd200-a-separate-module.patch usb/usb-storage-make-jumpshot-a-separate-module.patch usb/usb-storage-make-karma-a-separate-module.patch usb/usb-storage-make-onetouch-a-separate-module.patch usb/usb-storage-make-sddr09-a-separate-module.patch usb/usb-storage-make-sddr55-a-separate-module.patch usb/usb-storage-make-shuttle_usbat-a-separate-module.patch usb/usb-storage-prepare-for-subdriver-separation.patch usb.current/usb-usb-storage-add-ignore_residue-flag-for-genesys-logic-adapters.patch usb.current/usb-g_file_storage-automatically-disable-stalls-under-atmel.patch usb.current/usb-usb_get_string-should-check-the-descriptor-type.patch -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html