On Tuesday 24 February 2009, Alan Stern wrote: > This patch (as1220) automatically disables stalls when g_file_storage > finds itself running with an Atmel device controller, because the > Atmel hardware/driver isn't capable of halting bulk endpoints > correctly. > > Signed-off-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> > Reported-by: Stanislaw Gruszka <stf_xl@xxxxx> Acked-by: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx> Thanks. > > --- > > Index: usb-2.6/drivers/usb/gadget/file_storage.c > =================================================================== > --- usb-2.6.orig/drivers/usb/gadget/file_storage.c > +++ usb-2.6/drivers/usb/gadget/file_storage.c > @@ -3879,7 +3879,11 @@ static int __init check_parameters(struc > mod_data.protocol_type = USB_SC_SCSI; > mod_data.protocol_name = "Transparent SCSI"; > > - if (gadget_is_sh(fsg->gadget)) > + /* Some peripheral controllers are known not to be able to > + * halt bulk endpoints correctly. If one of them is present, > + * disable stalls. > + */ > + if (gadget_is_sh(fsg->gadget) || gadget_is_at91(fsg->gadget)) > mod_data.can_stall = 0; > > if (mod_data.release == 0xffff) { // Parameter wasn't set > > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html