On Friday 20 February 2009, Felipe Balbi wrote:
> > @@ -165,9 +165,19 @@ static void nuke(struct musb_ep *ep, con
> > if (is_dma_capable() && ep->dma) {
> > struct dma_controller *c = ep->musb->dma_controller;
> > int value;
> > +
> > if (ep->is_in) {
> > + u16 txcsr = musb_readw(epio, MUSB_TXCSR);
>
> this looks unnecessary, in the end you just wanna keep FLUSHFIFO set
> so...
>
> > +
> > + /*
> > + * The programming guide says that we must not clear
> > + * the DMAReqMode bit before DMAReqEnab, so we only
> > + * clear it in the second write...
> > + */
> > + txcsr &= MUSB_TXCSR_DMAMODE;
> > +
> > musb_writew(epio, MUSB_TXCSR,
> > - 0 | MUSB_TXCSR_FLUSHFIFO);
> > + txcsr | MUSB_TXCSR_FLUSHFIFO);
>
> musb_writew(epio, MUSB_TXCSR,
> 0 | MUSB_TXCSR_DMAMODE | MUSB_TXCSR_FLUSHFIFO);
> musb_writew(epio, MUSB_TXCSR, 0 | MUSB_TXCSR_FLUSHFIFO);
>
> should do it.
Will we be seeing an updated patch?
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
