Hi, Petr Cvek <petr.cvek@xxxxxx> writes: > It seems the USB product ID for g_webcam usb device gadget is > incorrectly used from EEM gadget "Ethernet Emulation Model". So > "webcam" device has a confusing description in lsusb: > > 1d6b:0102 Linux Foundation EEM Gadget > > I would change it to 0x0106, which is a next unassigned value > (according to http://www.linux-usb.org/usb.ids). Does this step > require some official communication with the holder of VID (Linux > Foundation)? Or all it takes is just to send patch to the kernel and > to the usb.ids database? > > I know it is only a cosmetic change on a legacy driver, but I assume > it would be better to have some default value for configfs API than to > borrow a PID from a whole different gadget. > > Change in question would be something like this (I will send a proper > patch after RFC): > > Fixing USB Product ID for UVC gadget (used from Ethernet Emulation > Model) and changing it to new one. Greg, do we still have an official Vendor ID? If so, any chance we can allocate a unique default ID for the webcam gadget? > Signed-off-by: Petr Cvek <petr.cvek@xxxxxx> > --- > drivers/usb/gadget/legacy/webcam.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/legacy/webcam.c b/drivers/usb/gadget/legacy/webcam.c > index f9661cd627c8..988814f2e1c7 100644 > --- a/drivers/usb/gadget/legacy/webcam.c > +++ b/drivers/usb/gadget/legacy/webcam.c > @@ -42,7 +42,7 @@ MODULE_PARM_DESC(trace, "Trace level bitmask"); > */ > > #define WEBCAM_VENDOR_ID 0x1d6b /* Linux Foundation */ > -#define WEBCAM_PRODUCT_ID 0x0102 /* Webcam A/V gadget */ > +#define WEBCAM_PRODUCT_ID 0x0106 /* UVC video gadget */ > #define WEBCAM_DEVICE_BCD 0x0010 /* 0.10 */ > > static char webcam_vendor_label[] = "Linux Foundation"; > -- > 2.11.0 > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- balbi
Attachment:
signature.asc
Description: PGP signature
