Hi Alan 2017-01-18 0:57 GMT+09:00 Alan Stern <stern@xxxxxxxxxxxxxxxxxxx>: > On Tue, 17 Jan 2017, Jaejoong Kim wrote: > >> The commonly use of a bottom half are tasklet and workqueue. The big >> difference between tasklet and workqueue is that the tasklet runs in >> an interrupt context and the workqueue runs in a process context, >> which means it can sleep if need be. >> >> The comment for usb_control/interrupt/bulk_msg() functions note that >> do not use this function within an interrupt context, like a 'bottom half' >> handler. With this comment, it makes confuse about usage of these functions. >> >> To more clarify, remove 'bottom half' comment. >> >> Signed-off-by: Jaejoong Kim <climbbb.kim@xxxxxxxxx> >> --- >> >> I not sure this change is needed. Just with my background, the bottom half technics >> are softirq(rarely used), tasklet and workqueue over 2.5 kernel version. >> And softirq and tasklet runs in interrupt context and workqueue runs in process contex. >> >> This functions are quite old but commonly used in usb device driver. That's why I read >> these function comments. :) >> >> If there are something wrong with my patch and patch's comment, please tell me. >> I am really appreciate with sharing your time for review this patch. > > Removing the stuff about bottom halves from the comments is fine. But > when you reformat the comments, you should not exceed the 80-column > limit. OK. I will resend a patch. Thanks for a comment. Jaejoong -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
