On Tue, Jan 17, 2017 at 07:28:29PM +0100, Greg KH wrote:
> On Tue, Jan 17, 2017 at 10:43:28AM -0600, Bin Liu wrote:
> > On Tue, Jan 17, 2017 at 05:23:48PM +0100, Greg KH wrote:
> > > On Tue, Jan 17, 2017 at 09:32:05AM -0600, Bin Liu wrote:
> > > > From: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
> > > >
> > > > Fixes the following sparse warning:
> > > >
> > > > drivers/usb/musb/musb_dsps.c:270:6: warning:
> > > > symbol 'dsps_musb_clear_ep_rxintr' was not declared. Should it be static?
> > > >
> > > > Signed-off-by: Wei Yongjun <weiyongjun1@xxxxxxxxxx>
> > > > Signed-off-by: Bin Liu <b-liu@xxxxxx>
> > > > ---
> > > > drivers/usb/musb/musb_dsps.c | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > You're kidding right?
> > >
> > > {sigh}
> > >
> > > Didn't we go through this last time?
> >
> > Last time was an accident, it was code cleanup which should go to -rc1.
> > But this compile warning is caused by a patch in v4.10-rc3, so I
> > consider it is a regression which should be addressed in -rc. I believe
> > I see others sending compile warning fixes in -rc.
>
> It's not a normal warning fix, it's only if you run sparse!
Ok.
>
> > I can feel your frustration from your lines of words, but sorry, this is
> > the only way I can learn how to be a maintainer. Please let me know if
> > you have recommendations.
>
> If it's not a bugfix or regression, then it needs to wait until the next
> major kernel release. Fixing up sparse "warnings" is not a normal
I know the role. The issue I have is how to correctly judge if a patch
is bugfix/regression or not, more accurately, if a fixup patch should
wait until next -rc1 or not...
> thing, and it can wait as obviously no one trips over this in normal
> operation.
I will try to use this on my judgement.
>
> You might want to read Documentation/development_model/ again :)
Sure, I will.
Regards,
-Bin.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
