Re: [PATCH 35/37] usb: host: xhci: remove newline from tracer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 12/29/2016 07:01 PM, Felipe Balbi wrote:
> If we add that newline, the output will like like the following:
>
>      kworker/2:1-42    [002] ....   169.811435: xhci_address_ctx:
> ctx_64=0, ctx_type=2, ctx_dma=@153fbd000, ctx_va=@ffff880153fbd000
>
> We would rather have that in a single line.
>
> Signed-off-by: Felipe Balbi <felipe.balbi@xxxxxxxxxxxxxxx>
> ---
>  drivers/usb/host/xhci-trace.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/xhci-trace.h b/drivers/usb/host/xhci-trace.h
> index 4bad0d6d2c8a..08bed2f07e50 100644
> --- a/drivers/usb/host/xhci-trace.h
> +++ b/drivers/usb/host/xhci-trace.h
> @@ -103,7 +103,7 @@ DECLARE_EVENT_CLASS(xhci_log_ctx,
>  			((HCC_64BYTE_CONTEXT(xhci->hcc_params) + 1) * 32) *
>  			((ctx->type == XHCI_CTX_TYPE_INPUT) + ep_num + 1));
>  	),
> -	TP_printk("\nctx_64=%d, ctx_type=%u, ctx_dma=@%llx, ctx_va=@%p",
> +	TP_printk("ctx_64=%d, ctx_type=%u, ctx_dma=@%llx, ctx_va=@%p",
>  			__entry->ctx_64, __entry->ctx_type,
>  			(unsigned long long) __entry->ctx_dma, __entry->ctx_va
>  	)

This patch looks good to me.

Best regards,
Lu Baolu
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux