On 29.12.2016 13:00, Felipe Balbi wrote:
process_ctrl_td() is too complex and difficult to read. We can clean it up a lot and maintain same functionality as before. Note that while cleaning up, one comment was introduced to explain the special case - it wasn't clear before from code. Much of the changes are related to removal of duplicated work done in both process_ctrl_td() and finish_td(). By removing the duplicated code, we could remove a few local variables and shuffle things around so the implementation is more straight forward. Signed-off-by: Felipe Balbi <felipe.balbi@xxxxxxxxxxxxxxx> ---
Postponing this one, control transfers need more attention as we discovered that we use one TD for the whole control transfer, SETUP+DATA+STATUS stages, while xhci specs indicate each stage should be a separate TD. this affects setting the urb->actual_length, especially in error cases and short transfers -Mathias -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
