On 01/13/2017 01:06 AM, Shuah Khan wrote: > On 12/26/2016 12:08 AM, Nobuo Iwata wrote: >> Implementation of new connect operation. This is linked as a part of >> usbip command. With this patch, usbip command has following operations. >> >> bind >> unbind >> list (local/remote) >> attach >> detach >> port >> connect ... this patch > > Don't include existing commands. Just list the new one. Why do you call > this connect. Isn't it really export - connect isn't accurate. Call it > export/unexport. > >> >> In device side node, this binds a device internally, sends an export >> request and receives export response. The definition of the request and >> response are defined in original code: tools/usb/usbip/usbip_network.h >> but was not used. They are corresponding to NEW-3 in following diagram. >> >> EXISTING) - invites devices from application(vhci)-side >> +------+ +------------------+ >> device--+ STUB | | application/VHCI | >> +------+ +------------------+ >> (server) (client) >> 1) # usbipd ... start daemon >> = = = >> 2) # usbip list --local >> 3) # usbip bind >> <--- list bound devices --- 4) # usbip list --remote >> <--- import a device ------ 5) # usbip attach >> = = = >> X disconnected 6) # usbip detach >> 7) usbip unbind >> >> NEW) - dedicates devices from device(stub)-side >> +------+ +------------------+ >> device--+ STUB | | application/VHCI | >> +------+ +------------------+ >> (client) (server) > > Make the left side server and right side client. I think you might be > using server and client network terminology. I would like to see server > as the system that has the device physically attached to. > > > I still want to see server as the one that is connected to the device. > It is just that in this new proposed model, server is exporting devices. > > Also does usbip run here in user mode. Can any user run uspip and initiate > export? If so, I don't think I can take this patch series. I don't like to > see non root being able to export and/or make attached devices public. > By default it's not possible. See my response to patch 9. Best regards, -- Krzysztof Opasiak Samsung R&D Institute Poland Samsung Electronics -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
