David Brownell wrote:
In fact, after having seen your changes, I'm not at all happy and have
to ask you to stop editing my patches and just point for what you think
needs to be improved.
Then when you write patch descriptions, put a lot more
effort into having them convey all the *important* info,
There was a patch where you have cut out most of the important information.
I did try to spend time of writing a good description but given the immense
workload that I've been subject to for the last several months, and that I was
in a hurry to post the patches before 2.6.28 (that turned to be a lost labor
anyway as nobody cared to look at them then, in December), I indeed managed to
skip one important piece in that case...
and not require more time to read and understand than
the actual patch. Be succinct; prioritize. Bigger is
not better.
I do reserve the right to the form of giving the information to myself. I
highly doubt that adjectives and adverbs that I used did hinder undestanding
anyhow.
Anyway, I'm not the first year in the open source, have tens of patches
merged and you could have saved time on teaching me, and even more on editing
my patches.
Several of those descriptions were actual obstacles
to the patch review.
I had an impression that you just skipped reading them in some cases.
That one run-on sentence sticks in my mind. It was
less than six lines only because your lines were so
very long ... clearly needed reformatting, and for
more reasons than the four spaces "git log" adds at
the beginning of each line.
I'm not using git for working with patch series (it doesn't fit well for
such task), so not following its git-log format.
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
