Hello, I wrote:
The driver prevents using the same numbered Rx/Tx endpoints
simultaneously for
the periodic transfers -- which would actually be correct unless
they share the
same FIFO. Use 'in_qh' and 'out_qh' fields of the 'struct
musb_hw_ep' to check
the endpoint's business and get rid of now completely useless
'periodic' array
in the 'struct musb'. While at it, optimize the loop induction
variable in the
endpoint lookup code and remove duplicate/unneeded code elsewhere...
Signed-off-by: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx>
Your patch comments need improvement. This would better be
titled "rewrite endpoint allocation", and the description
should highlight "make better use of resources".
No, the previous scheme was just based on the wrong assumption.
Not using something that's available is sub-optimal, but rarely a bug.
Well, the patch that this one replaced was classified a s a fix and
was in Greg's usb.current/ for some time (until I requested its
removal due to its brokennes). This is only a replacement, so you
should've really spoken up several months earlier. ;-)
... which you didn't back then in October/November. Instead I had to
fight off the horrible patch trying to fix the musb_h_disable() breakage
and adding more of its own...
for 2.6.29 merge.
What I'm going to do is send a replacement with a better
description and my signoff.
This doesn't seem to fix anything hurtful; so, it's not
I can only be happy if someone writes the patch description for me. :-)
In fact, after having seen your changes, I'm not at all happy and have
to ask you to stop editing my patches and just point for what you think
needs to be improved.
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
