On Tue, 2009-02-10 at 18:08 +0200, Felipe Balbi wrote: > On Tue, Feb 10, 2009 at 05:09:01PM +0100, ext Catalin Marinas wrote: > > On Tue, 2009-02-10 at 17:41 +0200, Felipe Balbi wrote: > > > On Tue, Feb 10, 2009 at 04:44:40PM +0100, ext Catalin Marinas wrote: > > > > On Tue, 2009-02-10 at 12:59 +0000, Russell King wrote: > > > > > On Tue, Feb 10, 2009 at 12:51:13PM +0000, Catalin Marinas wrote: > > > > > > + hcd = isp1760_register(mem_res->start, mem_size, irq_res->start, > > > > > > + IRQF_SHARED | IRQF_DISABLED, &pdev->dev, > > > > > > + dev_name(&pdev->dev), 0); > > > > > > > > > > Might want to pass the trigger flags as well? > > > > > > > > The defaults were fine on my board but to make it more generic, they > > > > should be passed via platform_device.platform_data from the platform > > > > code and I would need to move the flag definitions to an include/linux/ > > > > file. I can do this if there are no objections (or better ideas). > > > > > > how about using struct resource ?? > > > > The first 8 bits of the mem resource flags could be used but they seem > > to be already defined with a different meaning in the ioport.h file. Is > > it common practice to use those bits for device specific flags? > > you should use IRQ_TYPE_EDGE_RISING, IRQ_TYPE_EDGE_FALLING, etc. They > are defined in <linux/irq.h> Ah, I only now read Russell's comment properly. I thought he was referring to devflags, last argument of the isp1760_register() function. As for trigger flags, yes, it makes sense. Thanks. -- Catalin -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
