Re: [PATCH] Add platform device support for the ISP1760 USB chip

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Feb 10, 2009 at 04:44:40PM +0100, ext Catalin Marinas wrote:
> On Tue, 2009-02-10 at 12:59 +0000, Russell King wrote:
> > On Tue, Feb 10, 2009 at 12:51:13PM +0000, Catalin Marinas wrote:
> > > +   hcd = isp1760_register(mem_res->start, mem_size, irq_res->start,
> > > +                          IRQF_SHARED | IRQF_DISABLED, &pdev->dev,
> > > +                          dev_name(&pdev->dev), 0);
> >
> > Might want to pass the trigger flags as well?
> 
> The defaults were fine on my board but to make it more generic, they
> should be passed via platform_device.platform_data from the platform
> code and I would need to move the flag definitions to an include/linux/
> file. I can do this if there are no objections (or better ideas).

how about using struct resource ??

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux