Re: [PATCH] USB: musb: remove obsolete resume-signalling comments

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 04, 2016 at 03:20:04PM +0100, Johan Hovold wrote:
> Remove comments about resume signalling being stopped from
> GetPortStatus, something which is no longer the case.
> 
> Fixes: 8ed1fb790ea2 ("usb: musb: finish suspend/reset work...")
> Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>

Applied. Thanks.
-Bin.

> ---
>  drivers/usb/musb/musb_core.c    | 5 +----
>  drivers/usb/musb/musb_virthub.c | 1 -
>  2 files changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
> index 27dadc0d9114..bd58397e7c11 100644
> --- a/drivers/usb/musb/musb_core.c
> +++ b/drivers/usb/musb/musb_core.c
> @@ -569,10 +569,7 @@ static irqreturn_t musb_stage0_irq(struct musb *musb, u8 int_usb,
>  		if (devctl & MUSB_DEVCTL_HM) {
>  			switch (musb->xceiv->otg->state) {
>  			case OTG_STATE_A_SUSPEND:
> -				/* remote wakeup?  later, GetPortStatus
> -				 * will stop RESUME signaling
> -				 */
> -
> +				/* remote wakeup? */
>  				musb->port1_status |=
>  						(USB_PORT_STAT_C_SUSPEND << 16)
>  						| MUSB_PORT_STAT_RESUME;
> diff --git a/drivers/usb/musb/musb_virthub.c b/drivers/usb/musb/musb_virthub.c
> index 61b5f1c3c5bc..0b4595439d51 100644
> --- a/drivers/usb/musb/musb_virthub.c
> +++ b/drivers/usb/musb/musb_virthub.c
> @@ -132,7 +132,6 @@ void musb_port_suspend(struct musb *musb, bool do_suspend)
>  
>  		musb_dbg(musb, "Root port resuming, power %02x", power);
>  
> -		/* later, GetPortStatus will stop RESUME signaling */
>  		musb->port1_status |= MUSB_PORT_STAT_RESUME;
>  		schedule_delayed_work(&musb->finish_resume_work,
>  				      msecs_to_jiffies(USB_RESUME_TIMEOUT));
> -- 
> 2.7.3
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux