On 11/1/2016 4:14 AM, Felipe Balbi wrote: > > Hi, > > John Youn <johnyoun@xxxxxxxxxxxx> writes: >> From: Vardan Mikayelyan <mvardan@xxxxxxxxxxxx> >> >> Update the dwc2 driver for the new behavior of the usb_endpoint_maxp() >> and also use the new usb_endpoint_maxp_mult() helper function. >> >> This commit fixes failures in high-badwith ISOC transfer tests. >> >> Signed-off-by: Vardan Mikayelyan <mvardan@xxxxxxxxxxxx> >> Signed-off-by: John Youn <johnyoun@xxxxxxxxxxxx> >> --- >> drivers/usb/dwc2/gadget.c | 38 ++++++++++++++++++++------------------ >> 1 file changed, 20 insertions(+), 18 deletions(-) >> >> diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c >> index 8a7fd73..a505bbf 100644 >> --- a/drivers/usb/dwc2/gadget.c >> +++ b/drivers/usb/dwc2/gadget.c >> @@ -1812,17 +1812,17 @@ static u32 dwc2_hsotg_ep0_mps(unsigned int mps) >> * @hsotg: The driver state. >> * @ep: The index number of the endpoint >> * @mps: The maximum packet size in bytes >> + * @mc: The multicount value >> * >> * Configure the maximum packet size for the given endpoint, updating >> * the hardware control registers to reflect this. >> */ >> static void dwc2_hsotg_set_ep_maxpacket(struct dwc2_hsotg *hsotg, >> - unsigned int ep, unsigned int mps, unsigned int dir_in) >> + unsigned int ep, unsigned int mps, >> + unsigned int mc, unsigned int dir_in) > > this has an odd set of arguments. You pass the ep index, mps, direction > and mult value, when you could just pass hsotg_ep and descriptor instead. Yes looks like we can do some simplification here. And you probably don't need to pass a descriptor either since it must be set in the usb_ep before enable. However this is also called in some contexts where a descriptor is not available (initialization and ep0). So we have to think about this a bit. I think dwc3 can make similar simplification on the __dwc3_gadget_ep_enable(). > > Anyway, this is in my testing/next now. > Ok thanks. Regards, John -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
