Re: [PATCH] usb: dwc2: gadget: Update for new usb_endpoint_maxp()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

John Youn <johnyoun@xxxxxxxxxxxx> writes:
> From: Vardan Mikayelyan <mvardan@xxxxxxxxxxxx>
>
> Update the dwc2 driver for the new behavior of the usb_endpoint_maxp()
> and also use the new usb_endpoint_maxp_mult() helper function.
>
> This commit fixes failures in high-badwith ISOC transfer tests.
>
> Signed-off-by: Vardan Mikayelyan <mvardan@xxxxxxxxxxxx>
> Signed-off-by: John Youn <johnyoun@xxxxxxxxxxxx>
> ---
>  drivers/usb/dwc2/gadget.c | 38 ++++++++++++++++++++------------------
>  1 file changed, 20 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/usb/dwc2/gadget.c b/drivers/usb/dwc2/gadget.c
> index 8a7fd73..a505bbf 100644
> --- a/drivers/usb/dwc2/gadget.c
> +++ b/drivers/usb/dwc2/gadget.c
> @@ -1812,17 +1812,17 @@ static u32 dwc2_hsotg_ep0_mps(unsigned int mps)
>   * @hsotg: The driver state.
>   * @ep: The index number of the endpoint
>   * @mps: The maximum packet size in bytes
> + * @mc: The multicount value
>   *
>   * Configure the maximum packet size for the given endpoint, updating
>   * the hardware control registers to reflect this.
>   */
>  static void dwc2_hsotg_set_ep_maxpacket(struct dwc2_hsotg *hsotg,
> -			unsigned int ep, unsigned int mps, unsigned int dir_in)
> +					unsigned int ep, unsigned int mps,
> +					unsigned int mc, unsigned int dir_in)

this has an odd set of arguments. You pass the ep index, mps, direction
and mult value, when you could just pass hsotg_ep and descriptor instead.

Anyway, this is in my testing/next now.

-- 
balbi

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux