Re: [PATCH 2/4] USB: ch341: reinitialize chip on reconfiguration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 24, 2016 at 4:24 PM, Johan Hovold <johan@xxxxxxxxxx> wrote:
> On Sat, Oct 22, 2016 at 10:14:21PM +0100, Aidan Thornton wrote:
>> Sent, but please pay close attention to the new note in patch 2 about
>> higher baud rates. It turns out the timings for baud rates above 500kbaud
>> are out of spec. This isn't a regression on the CH340G - they're exactly
>> the same before and after, so far as I can tell - but it might be on the
>> CH341 if baud rate setting worked better there before. Grigori might have
>> to take a look at that. Sorry for the inconvenience. (I'm not sure an
>> in-spec 576kbaud is even possible on the CH340G.)
>
> Thanks for pointing that out. According to the datasheets these devices
> are supposed to support rates up to 2 Mbaud, but perhaps the
> (reverse-engineered?) baud-rate algorithm is still too limited.
>
> I'm inclined to just merge these and try to deal with any potential fall
> out later. I've asked Winchiphead if they can provide some further
> insight. Let's see how it goes.

Thanks for the merge! Hopefully there shouldn't be any major fallout
(touch wood). I think it's just a rounding error in the calculation -
after looking at the datasheet it doesn't list 576000 as supported,
which is probably why that's not possible - but the fix wasn't
immediately obvious
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux