On Sat, Oct 22, 2016 at 10:14:21PM +0100, Aidan Thornton wrote: > On 22 Oct 2016 15:56, "Johan Hovold" <johan@xxxxxxxxxx> wrote: > > > > On Sat, Oct 22, 2016 at 03:24:56PM +0100, Aidan Thornton wrote: > > > On 19 Oct 2016 09:42, "Johan Hovold" <johan@xxxxxxxxxx> wrote: > > > > > > > > On Wed, Oct 19, 2016 at 09:26:39AM +0200, Grigori Goronzy wrote: > > > > > So let's just undo the change to the initialization sequence and get > > > > > this merged. Then we can tune or simplify the init sequence in the > next > > > > > series. That is the process you propose, right? > > > > > > > > Yes. That LCR write could either stay or be removed completely from > this > > > > series, and then the rest can be cleaned up through follow-ons using > the > > > > vendor driver as inspiration. > > > > > > OK, guess I'll submit a version of the patch series which doesn't change > > > that LCR write since it doesn't have any obvious detrimental effect and > the > > > init sequence will probably want cleaning up later anyway, unless you > have > > > any objections. Probably later today, sorry for the delay. > > > > Sounds good to me. > > Sent, but please pay close attention to the new note in patch 2 about > higher baud rates. It turns out the timings for baud rates above 500kbaud > are out of spec. This isn't a regression on the CH340G - they're exactly > the same before and after, so far as I can tell - but it might be on the > CH341 if baud rate setting worked better there before. Grigori might have > to take a look at that. Sorry for the inconvenience. (I'm not sure an > in-spec 576kbaud is even possible on the CH340G.) Thanks for pointing that out. According to the datasheets these devices are supposed to support rates up to 2 Mbaud, but perhaps the (reverse-engineered?) baud-rate algorithm is still too limited. I'm inclined to just merge these and try to deal with any potential fall out later. I've asked Winchiphead if they can provide some further insight. Let's see how it goes. Thanks, Johan -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
