On Wed, Sep 28, 2016 at 05:15:59PM +0300, Felipe Balbi wrote: > > Hi, > > Bin Liu <b-liu@xxxxxx> writes: > >> > uvc_video set the each request size (you could check function > >> > uvc_video_alloc_requests()) for uvc: > >> > req_size = video->ep->maxpacket > >> > * max_t(unsigned int, video->ep->maxburst, 1) > >> > * (video->ep->mult + 1); > >> > > >> > > >> > If we change the ep->maxpacket like this, uvc layer will only set the > >> > req size to 1024 (while it should be 3072 if we want to use high > >> > bindwidth isoc transfer). > >> > >> it'll be 1024 * (mult + 1). Hmm, mult isn't set for highspeed isoc > >> endpoints. So here you go: > > > > Great! all the 4 patches you sent so far fix the issue on v4.4.21 tag! > > Now I see 3 1024-bytes transactions in each SOF. > > cool, I just sent a huge patch bomb which contains all these tiny fixes > plus a rework of usb_endpoint_maxp(). Care to give a round of review so > we get it into v4.10 (not v4.9, that's too late) merge window? Sure, will do soon. > > thanks for testing. If it's not too much to ask, care to test my > v4.4.21+dwc3 branch? I force-pushed all latest changes to that branch so > it's easy for you to test. No problem, I will test it in a couple days. I have to jump in another urgent task which popped up yesterday. > > Please make sure to capture dwc3's tracepoints, I need to make sure > we're printing things correctly now ;-) Yes, I will capture it. > > Best > > -- > balbi Regards, -Bin -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
