Re: [PATCH 1/2] usb: add helper to extract bits 12:11 of wMaxPacketSize

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Bin Liu <b-liu@xxxxxx> writes:
>> >> @@ -630,6 +635,20 @@ static inline int usb_endpoint_maxp(const struct usb_endpoint_descriptor *epd)
>> >>  	return __le16_to_cpu(epd->wMaxPacketSize);
>> >>  }
>> >>
>> >> +/**
>> >> + * usb_endpoint_isoc_maxp_mult - get endpoint's transactional opportunities
>> >> + * @epd: endpoint to be checked
>> >> + *
>> >> + * Return @epd's wMaxPacketSize[12:11] + 1
>> >> + */
>> >> +static inline int
>> >> +usb_endpoint_isoc_maxp_mult(const struct usb_endpoint_descriptor *epd)
>> >> +{
>> >> +	int maxp = __le16_to_cpu(epd->wMaxPacketSize);
>> >> +
>> >> +	return USB_EP_ISOC_MAXP_MULT(maxp) + 1;
>> >> +}
>> >> +
>> >>  static inline int usb_endpoint_interrupt_type(
>> >>  		const struct usb_endpoint_descriptor *epd)
>> >>  {
>> >>
>> > Does this mean the issue of isoc high bandwidth transfer was fixed by
>> > this patchset per your test?
>> 
>> No, I couldn't get g_webcam to work yet.
>
> In mainline, g_webcam is broken with DWC3. Also these two patches don't
> fix the issue on v4.4.21.

care to send tracepoint output? Best if you could cherry pick my latest
tracepoint changes so we have the best output possible.

I have also built a branch with v4.4.21 + all dwc3 patches (except for
device properties and PCI stuff) which you could use for testing. If you
run with that, then I can get proper trace output and I can try to
figure out what's missing.

Branch is here:

  git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git usb/v4.4.21+dwc3

thanks

-- 
balbi

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux