Hi, yfw <nh26223@xxxxxxxxx> writes: > Hi Felipe, > > On 2016/9/28 22:15, Felipe Balbi wrote: >> >> Hi, >> >> Bin Liu <b-liu@xxxxxx> writes: >>>>> uvc_video set the each request size (you could check function >>>>> uvc_video_alloc_requests()) for uvc: >>>>> req_size = video->ep->maxpacket >>>>> * max_t(unsigned int, video->ep->maxburst, 1) >>>>> * (video->ep->mult + 1); >>>>> >>>>> >>>>> If we change the ep->maxpacket like this, uvc layer will only set the >>>>> req size to 1024 (while it should be 3072 if we want to use high >>>>> bindwidth isoc transfer). >>>> >>>> it'll be 1024 * (mult + 1). Hmm, mult isn't set for highspeed isoc >>>> endpoints. So here you go: >>> >>> Great! all the 4 patches you sent so far fix the issue on v4.4.21 tag! >>> Now I see 3 1024-bytes transactions in each SOF. >> >> cool, I just sent a huge patch bomb which contains all these tiny fixes >> plus a rework of usb_endpoint_maxp(). Care to give a round of review so >> we get it into v4.10 (not v4.9, that's too late) merge window? > I have already reviewed all the patches related. You could add my "reviewed-by". You need to reply on the actual thread, with a real name, sorry. Have a look at Documentation/SubmittingPatches. > And thanks a lot for looking at this issue. yeah, no problem -- balbi
Attachment:
signature.asc
Description: PGP signature
