Re: [PATCH 1/2] usb: add helper to extract bits 12:11 of wMaxPacketSize

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 2016/9/27 23:12, Bin Liu wrote:
On Tue, Sep 27, 2016 at 11:02:54PM +0800, yfw wrote:


On 2016/9/27 23:00, Bin Liu wrote:
On Tue, Sep 27, 2016 at 10:53:54PM +0800, yfw wrote:
Hi,

On 2016/9/27 22:28, Bin Liu wrote:
On Tue, Sep 27, 2016 at 09:20:56AM -0500, Bin Liu wrote:
Felipe,

On Tue, Sep 27, 2016 at 10:18:26AM +0300, Felipe Balbi wrote:

[snip]

Does this mean the issue of isoc high bandwidth transfer was fixed by
this patchset per your test?

No, I couldn't get g_webcam to work yet.

In mainline, g_webcam is broken with DWC3. Also these two patches don't
fix the issue on v4.4.21.

care to send tracepoint output? Best if you could cherry pick my latest
tracepoint changes so we have the best output possible.

I have also built a branch with v4.4.21 + all dwc3 patches (except for
device properties and PCI stuff) which you could use for testing. If you
run with that, then I can get proper trace output and I can try to
figure out what's missing.

Branch is here:

git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git usb/v4.4.21+dwc3

This branch does not generate the isoch traffic (on ep2in). ftrace
attached (dwc3-g_webcam-v4.4.21+tp.ftrace).

I also attached the ftrace log for v4.4.21 tag
(dwc3-g_webcam-v4.4.21.ftrace) for comparison, which has ep2in isoch
traffic, but only one transaction per SOF.

Sorry, I didn't realize the ftrace file size is huge. Attached the
tarball here.
(dwc3-g_webcam-ftrace.tgz)

Regards,
-Bin.

>From the ftrace log:

irq/441-dwc3-769   [001] d..2   101.207679: dwc3_gadget: ep2in-isoc: req
ed971b00 dma ad9d2000 length 5120
5120 looks wrong to me. 5120 == 0x1400. There is an issue in uvc_video which
set the req_size according maxpacket (which is 0x1400 for high bandwidth isoc).
What about this?

Yeah, seems not right to me too. The UDC would only have 1024 bytes to
transmit.



irq/441-dwc3-769   [001] d..2   101.207682: dwc3_prepare_trb: ep2in-isoc:
trb f2037020 bph 00000000 bpl ad9d2000 size 00001400 ctrl 00000c69

Looks like the "bits 12:11 of wMaxPacketSize" patch from Felipe was not applied.

No, I didn't. I was trying to give a trace for the base line to start
with.
Get it. Waiting for your further testing result.

I am waiting for Felipe's next instruction - going on v4.4.21 tag or his
v4.4.21+dwc3 HEAD.
Is it possible that you try "bits 12:11 of wMaxPacketSize" patches from Felipe
with your current HEAD now?
You may hardcode the req_size (3072) in uvc_video (only for test).

Regards
Yin, Fengwei


Regards,
-Bin.


Regards
Yin, Fengwei


Regards,
-Bin.


irq/441-dwc3-769   [001] d..2   101.208357: dwc3_complete_trb: ep2in-isoc:
trb f2037020 bph 00000000 bpl ad9d2000 size 10001400 ctrl 1bfd0c68

MissedIsoc happened.


Regards
Yin, Fengwei

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux