Re: [RFT PATCH 0/2] usb: dwc3: of-simple: add support for Calvium's dwc3

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Lars Melin <larsm17@xxxxxxxxx> writes:

> On 2016-09-13 12:47, Felipe Balbi wrote:
>> "Steven J. Hill" <Steven.Hill@xxxxxxxxxx> writes:
>>
>>> On 09/12/2016 02:18 PM, Felipe Balbi wrote:
>>>>
>>>> Please give this a shot. Patches are still RFT
>>>> because, well, they need testing. Note also that I
>>>> haven't, yet, added a binding documentation for your
>>>> compatible flag. I'll do that on V2 of the patchset.
>>>>
>>> Hey Felipe.
>>>
>>> Using your changes, the 'dwc3-of-simple' code works
>>> nicely for our platform. Everything tests out. You
>>> have my 'Tested-by' for the patches. Thanks.
>>
>> Thanks a lot, I have pushed this to my testing/next. It'll be part of
>> v4.9 merge window.
>>
>
> Just don't call it Calvium, eh!

heh, thanks. Fixed it up :-)

commit b281dc630b41cd5d0c8600ffb3230ef9dc222b30
Author: Felipe Balbi <felipe.balbi@xxxxxxxxxxxxxxx>
Date:   Mon Sep 12 21:24:58 2016 +0300

    usb: dwc3: of-simple: add compatible for Cavium
    
    Add necessary compatible flag for Cavium's DWC3 so
    dwc3-of-simple will probe.
    
    Tested-by: Steven J. Hill <Steven.Hill@xxxxxxxxxx>
    Signed-off-by: Felipe Balbi <felipe.balbi@xxxxxxxxxxxxxxx>

diff --git a/Documentation/devicetree/bindings/usb/dwc3-cavium.txt b/Documentation/devicetree/bindings/usb/dwc3-cavium.txt
new file mode 100644
index 000000000000..710b782ccf65
--- /dev/null
+++ b/Documentation/devicetree/bindings/usb/dwc3-cavium.txt
@@ -0,0 +1,28 @@
+Cavium SuperSpeed DWC3 USB SoC controller
+
+Required properties:
+- compatible:  Should contain "cavium,octeon-7130-usb-uctl"
+
+Required child node:
+A child node must exist to represent the core DWC3 IP block. The name of
+the node is not important. The content of the node is defined in dwc3.txt.
+
+Example device node:
+
+                   uctl@1180069000000 {
+                           compatible = "cavium,octeon-7130-usb-uctl";
+                           reg = <0x00011800 0x69000000 0x00000000 0x00000100>;
+                           ranges;
+                           #address-cells = <0x00000002>;
+                           #size-cells = <0x00000002>;
+                           refclk-frequency = <0x05f5e100>;
+                           refclk-type-ss = "dlmc_ref_clk0";
+                           refclk-type-hs = "dlmc_ref_clk0";
+                           power = <0x00000002 0x00000002 0x00000001>;
+                           xhci@1690000000000 {
+                                   compatible = "cavium,octeon-7130-xhci", "synopsys,dwc3";
+                                   reg = <0x00016900 0x00000000 0x00000010 0x00000000>;
+                                   interrupt-parent = <0x00000010>;
+                                   interrupts = <0x00000009 0x00000004>;
+                           };
+                   };
diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c
index ed6bbb31ec90..fe414e7a9c78 100644
--- a/drivers/usb/dwc3/dwc3-of-simple.c
+++ b/drivers/usb/dwc3/dwc3-of-simple.c
@@ -176,6 +176,7 @@ static const struct of_device_id of_dwc3_simple_match[] = {
        { .compatible = "qcom,dwc3" },
        { .compatible = "rockchip,rk3399-dwc3" },
        { .compatible = "xlnx,zynqmp-dwc3" },
+       { .compatible = "cavium,octeon-7130-usb-uctl" },
        { /* Sentinel */ }
 };
 MODULE_DEVICE_TABLE(of, of_dwc3_simple_match);


-- 
balbi

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux