On 08/31/2016 12:27 PM, Oliver Neukum wrote: > On Fri, 2016-08-26 at 18:02 +0000, Binyamin Sharet (bsharet) wrote: > >> I think the reason is that in case of quirks == NO_UNION_NORMAL it gets the data >> and control interfaces and then jumps to skip_normal probe, in which case there are no >> checks whether data_interface, data_interface->cur_altsetting or control_interface are NULL. >> >> Also, even in the case where quirks != NO_UNION_NORMAL, if the control and the data >> interfaces are not the same, there is no check whether data_interface->cur_altsetting is NULL. >> (before the first line of code in skip_normal_probe) which may cause the first check to dereference >> a NULL pointer. > Hi, > > could you test this updated patch? > > Regards > Oliver > Hi Oliver, Sure, but could you send me the cdc-acm.c file that this patch applies to? Otherwise I need to patch it manually each time... -- Binyamin Sharet, Cisco, STARE-C -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html