On Sat, Aug 20, 2016 at 01:29:41PM +0300, Aleksandr Makarov wrote:
> From: Aleksandr Makarov <aleksandr.o.makarov@xxxxxxxxx>
>
> USB: serial: option: add WeTelecom WM-D200
This does not belong in the commit message (mail body).
> Add support for WeTelecom WM-D200.
>
> T: Bus=03 Lev=01 Prnt=01 Port=01 Cnt=01 Dev#= 4 Spd=12 MxCh= 0
> D: Ver= 1.10 Cls=00(>ifc ) Sub=00 Prot=00 MxPS=64 #Cfgs= 1
> P: Vendor=22de ProdID=6801 Rev=00.00
> S: Manufacturer=WeTelecom Incorporated
> S: Product=WeTelecom Mobile Products
> C: #Ifs= 4 Cfg#= 1 Atr=80 MxPwr=500mA
> I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
> I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
> I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none)
> I: If#= 3 Alt= 0 #EPs= 2 Cls=08(stor.) Sub=06 Prot=50 Driver=usb-storage
>
> Signed-off-by: Aleksandr Makarov <aleksandr.o.makarov@xxxxxxxxx>
> ---
When resending a patch, please include a changelog here, below the
cut-off line.
Also don't resend as a response with quoted text below the patch. Take a
look at git format-patch and git send-email for a convenient way to
generate and submit a patch on the right format.
> --- drivers/usb/serial/option.c.orig 2016-08-19 15:15:17.173146316 +0300
> +++ drivers/usb/serial/option.c 2016-08-19 15:16:04.241147738 +0300
> @@ -519,6 +519,10 @@ static void option_instat_callback(struc
> #define VIATELECOM_VENDOR_ID 0x15eb
> #define VIATELECOM_PRODUCT_CDS7 0x0001
>
> +/* WeTelecom products */
> +#define WETELECOM_VENDOR_ID 0x22de
> +#define WETELECOM_PRODUCT_WMD200 0x6801
And the values here were not aligned.
> +
> struct option_blacklist_info {
> /* bitmask of interface numbers blacklisted for send_setup */
> const unsigned long sendsetup;
> @@ -1969,6 +1973,7 @@ static const struct usb_device_id option
> { USB_DEVICE_INTERFACE_CLASS(0x2020, 0x4000, 0xff) }, /* OLICARD300 - MT6225 */
> { USB_DEVICE(INOVIA_VENDOR_ID, INOVIA_SEW858) },
> { USB_DEVICE(VIATELECOM_VENDOR_ID, VIATELECOM_PRODUCT_CDS7) },
> + { USB_DEVICE_AND_INTERFACE_INFO(WETELECOM_VENDOR_ID, WETELECOM_PRODUCT_WMD200, 0xff, 0xff, 0xff) },
> { } /* Terminating entry */
> };
> MODULE_DEVICE_TABLE(usb, option_ids);
>
> 20.08.2016 13:05, Greg KH пишет:
> > On Sat, Aug 20, 2016 at 11:19:37AM +0300, Aleksandr Makarov wrote:
> >> From: Aleksandr Makarov <aleksandr.o.makarov@xxxxxxxxx>
So this does not belong here either.
I fixed up the above before applying, but please consider this feedback
for next time.
Thanks,
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
